jamey/simpleshop_theme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: use assigns spread in page LiveView render functions

Browse Source 
Replace verbose explicit attr passing with {assigns} spread for
home, contact, cart, product show and checkout success LiveViews.
Collection skipped (inline rendering, no template component).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jamey 2026-02-08 10:53:06 +00:00
parent 5a43cfc761
commit db02c0b414
5 changed files with 6 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/simpleshop_theme_web/live/shop_live/cart.ex
View File

@ -65,22 +65,10 @@ defmodule SimpleshopThemeWeb.ShopLive.Cart do
@impl true
def render(assigns) do
cart_page_subtotal = Cart.calculate_subtotal(assigns.cart_items)
assigns = assign(assigns, :cart_page_subtotal, cart_page_subtotal)
assigns = assign(assigns, :cart_page_subtotal, Cart.calculate_subtotal(assigns.cart_items))
~H"""
<SimpleshopThemeWeb.PageTemplates.cart
theme_settings={@theme_settings}
logo_image={@logo_image}
header_image={@header_image}
cart_items={@cart_items}
cart_page_subtotal={@cart_page_subtotal}
mode={@mode}
cart_count={@cart_count}
cart_subtotal={@cart_subtotal}
cart_drawer_open={@cart_drawer_open}
cart_status={@cart_status}
/>
<SimpleshopThemeWeb.PageTemplates.cart {assigns} />
"""
end
end

13
lib/simpleshop_theme_web/live/shop_live/checkout_success.ex
View File

@ -65,18 +65,7 @@ defmodule SimpleshopThemeWeb.ShopLive.CheckoutSuccess do
@impl true
def render(assigns) do
~H"""
<SimpleshopThemeWeb.PageTemplates.checkout_success
theme_settings={@theme_settings}
logo_image={@logo_image}
header_image={@header_image}
mode={@mode}
cart_items={@cart_items}
cart_count={@cart_count}
cart_subtotal={@cart_subtotal}
cart_drawer_open={@cart_drawer_open}
cart_status={@cart_status}
order={@order}
/>
<SimpleshopThemeWeb.PageTemplates.checkout_success {assigns} />
"""
end
end

12
lib/simpleshop_theme_web/live/shop_live/contact.ex
View File

@ -38,17 +38,7 @@ defmodule SimpleshopThemeWeb.ShopLive.Contact do
@impl true
def render(assigns) do
~H"""
<SimpleshopThemeWeb.PageTemplates.contact
theme_settings={@theme_settings}
logo_image={@logo_image}
header_image={@header_image}
mode={@mode}
cart_items={@cart_items}
cart_count={@cart_count}
cart_subtotal={@cart_subtotal}
cart_drawer_open={@cart_drawer_open}
cart_status={@cart_status}
/>
<SimpleshopThemeWeb.PageTemplates.contact {assigns} />
"""
end
end

13
lib/simpleshop_theme_web/live/shop_live/home.ex
View File

@ -44,18 +44,7 @@ defmodule SimpleshopThemeWeb.ShopLive.Home do
@impl true
def render(assigns) do
~H"""
<SimpleshopThemeWeb.PageTemplates.home
theme_settings={@theme_settings}
logo_image={@logo_image}
header_image={@header_image}
preview_data={@preview_data}
mode={@mode}
cart_items={@cart_items}
cart_count={@cart_count}
cart_subtotal={@cart_subtotal}
cart_drawer_open={@cart_drawer_open}
cart_status={@cart_status}
/>
<SimpleshopThemeWeb.PageTemplates.home {assigns} />
"""
end
end

20
lib/simpleshop_theme_web/live/shop_live/product_show.ex
View File

@ -173,25 +173,7 @@ defmodule SimpleshopThemeWeb.ShopLive.ProductShow do
@impl true
def render(assigns) do
~H"""
<SimpleshopThemeWeb.PageTemplates.pdp
theme_settings={@theme_settings}
logo_image={@logo_image}
header_image={@header_image}
product={@product}
gallery_images={@gallery_images}
related_products={@related_products}
quantity={@quantity}
mode={@mode}
cart_items={@cart_items}
cart_count={@cart_count}
cart_subtotal={@cart_subtotal}
cart_drawer_open={@cart_drawer_open}
cart_status={@cart_status}
option_types={@option_types}
selected_options={@selected_options}
available_options={@available_options}
display_price={@display_price}
/>
<SimpleshopThemeWeb.PageTemplates.pdp {assigns} />
"""
end
end