From db02c0b41441db0b70aa96537ed3397e086d2649 Mon Sep 17 00:00:00 2001 From: jamey Date: Sun, 8 Feb 2026 10:53:06 +0000 Subject: [PATCH] refactor: use assigns spread in page LiveView render functions Replace verbose explicit attr passing with {assigns} spread for home, contact, cart, product show and checkout success LiveViews. Collection skipped (inline rendering, no template component). Co-Authored-By: Claude Opus 4.6 --- .../live/shop_live/cart.ex | 16 ++------------- .../live/shop_live/checkout_success.ex | 13 +----------- .../live/shop_live/contact.ex | 12 +---------- .../live/shop_live/home.ex | 13 +----------- .../live/shop_live/product_show.ex | 20 +------------------ 5 files changed, 6 insertions(+), 68 deletions(-) diff --git a/lib/simpleshop_theme_web/live/shop_live/cart.ex b/lib/simpleshop_theme_web/live/shop_live/cart.ex index 3e2caf3..337e974 100644 --- a/lib/simpleshop_theme_web/live/shop_live/cart.ex +++ b/lib/simpleshop_theme_web/live/shop_live/cart.ex @@ -65,22 +65,10 @@ defmodule SimpleshopThemeWeb.ShopLive.Cart do @impl true def render(assigns) do - cart_page_subtotal = Cart.calculate_subtotal(assigns.cart_items) - assigns = assign(assigns, :cart_page_subtotal, cart_page_subtotal) + assigns = assign(assigns, :cart_page_subtotal, Cart.calculate_subtotal(assigns.cart_items)) ~H""" - + """ end end diff --git a/lib/simpleshop_theme_web/live/shop_live/checkout_success.ex b/lib/simpleshop_theme_web/live/shop_live/checkout_success.ex index 613d2b6..5dff297 100644 --- a/lib/simpleshop_theme_web/live/shop_live/checkout_success.ex +++ b/lib/simpleshop_theme_web/live/shop_live/checkout_success.ex @@ -65,18 +65,7 @@ defmodule SimpleshopThemeWeb.ShopLive.CheckoutSuccess do @impl true def render(assigns) do ~H""" - + """ end end diff --git a/lib/simpleshop_theme_web/live/shop_live/contact.ex b/lib/simpleshop_theme_web/live/shop_live/contact.ex index 1523193..07c9183 100644 --- a/lib/simpleshop_theme_web/live/shop_live/contact.ex +++ b/lib/simpleshop_theme_web/live/shop_live/contact.ex @@ -38,17 +38,7 @@ defmodule SimpleshopThemeWeb.ShopLive.Contact do @impl true def render(assigns) do ~H""" - + """ end end diff --git a/lib/simpleshop_theme_web/live/shop_live/home.ex b/lib/simpleshop_theme_web/live/shop_live/home.ex index 6a2099b..793eb58 100644 --- a/lib/simpleshop_theme_web/live/shop_live/home.ex +++ b/lib/simpleshop_theme_web/live/shop_live/home.ex @@ -44,18 +44,7 @@ defmodule SimpleshopThemeWeb.ShopLive.Home do @impl true def render(assigns) do ~H""" - + """ end end diff --git a/lib/simpleshop_theme_web/live/shop_live/product_show.ex b/lib/simpleshop_theme_web/live/shop_live/product_show.ex index d9092a0..0962eb4 100644 --- a/lib/simpleshop_theme_web/live/shop_live/product_show.ex +++ b/lib/simpleshop_theme_web/live/shop_live/product_show.ex @@ -173,25 +173,7 @@ defmodule SimpleshopThemeWeb.ShopLive.ProductShow do @impl true def render(assigns) do ~H""" - + """ end end