jamey/berrypod
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix visual regressions in admin CSS refactor

Browse Source 
Five missing line-height values caused pixel shifts when Tailwind
utilities (text-sm, text-lg, text-xs) were replaced with semantic
classes that only set font-size. Also remove phantom padding-bottom
on .admin-header (the old pb-4 utility was never defined).

Fixes: .admin-header, .admin-header-subtitle, .admin-error,
.admin-brand, .admin-text-secondary

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jamey 2026-03-01 19:39:22 +00:00
parent b7ec41b0cf
commit 867a69109e
4 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
PROGRESS.md
View File

@ -33,6 +33,10 @@ Tier 1 MVP complete. Tier 2 production readiness complete (except Litestream and
## Next up
### Admin CSS refactor ([plan](docs/plans/css-migration.md))
Phase 2 in progress — replacing Tailwind utility clones with semantic CSS classes. Layout shell, core components, and 6 page templates refactored (newsletter, settings, providers, theme, order_show). 11 templates still use utility classes; `utilities.css` stays until they're done. Visual regression fixes applied (5 missing line-height/padding corrections). Phases 1 (layer cascade) and 4 (delete utilities.css) blocked until all templates are migrated.
### Profit-aware pricing & sales ([plan](docs/plans/profit-aware-pricing.md))
| # | Task | Depends on | Est | Status |

4
assets/css/admin.css
View File

@ -8,11 +8,9 @@
@import "./theme-layer2-attributes.css";
@import "./theme-semantic.css";
/* Admin components, layout, icons, and transitions */
/* Admin components, icons, and utilities */
@import "./admin/components.css";
@import "./admin/layout.css";
@import "./admin/icons.css";
@import "./admin/transitions.css";
@import "./admin/utilities.css";
/* LiveView loading state variants */

6
assets/css/admin/components.css
View File

@ -226,7 +226,7 @@
/* ── Page header ── */
.admin-header {
padding-bottom: 1rem;
/* pb-4 was never defined in utilities — no padding in original */
}
.admin-header-with-actions {
@ -244,6 +244,7 @@
.admin-header-subtitle {
font-size: 0.875rem;
line-height: 1.25rem;
color: color-mix(in oklch, var(--t-text-primary) 70%, transparent);
}
@ -827,6 +828,7 @@
gap: 0.5rem;
margin-top: 0.375rem;
font-size: 0.875rem;
line-height: 1.25rem;
color: var(--t-status-error);
}
@ -3165,6 +3167,7 @@
/* Brand wordmark in sidebar */
.admin-brand {
font-size: 1.125rem;
line-height: 1.75rem;
font-weight: 700;
letter-spacing: -0.025em;
}
@ -3172,6 +3175,7 @@
/* Secondary text for user email, help text, meta info */
.admin-text-secondary {
font-size: 0.75rem;
line-height: 1rem;
color: color-mix(in oklch, var(--t-text-primary) 60%, transparent);
}

2
docs/plans/css-migration.md
View File

@ -1,6 +1,6 @@
# Plan: CSS migration — Tailwind + DaisyUI to modern hand-written CSS
Status: Complete (all phases 0-8)
Status: Complete (all phases 0-8). Admin CSS semantic refactor in progress — see PROGRESS.md.
## Overview