jamey/simpleshop_theme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
f29772010e
simpleshop_theme/lib/simpleshop_theme_web/components/layouts
History
Jamey Greenwood f29772010e fix: resolve nested HTML documents causing LiveView binding errors 
The shop.html.heex and shop_root.html.heex were both full HTML documents.
When nested (root layout + live layout), this created invalid HTML with
duplicate <!DOCTYPE>, <html>, <head>, and <body> tags.

This caused:
- "Cannot bind multiple views to the same DOM element" console errors
- Failed Lighthouse audits
- Potential rendering issues

Fix:
- shop_root.html.heex: Now contains the full HTML document with theme
  settings, CSS variables, and data attributes
- shop.html.heex: Now just passes through @inner_content

Results:
- Console errors: Gone
- Best Practices: 96 → 100
- Total Blocking Time: 140ms → 30ms
- HTML validation: Passes

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-21 20:20:39 +00:00
..
root.html.heex perf: self-host fonts and add /admin route 2026-01-20 22:54:07 +00:00
shop_root.html.heex fix: resolve nested HTML documents causing LiveView binding errors 2026-01-21 20:20:39 +00:00
shop.html.heex fix: resolve nested HTML documents causing LiveView binding errors 2026-01-21 20:20:39 +00:00