merge page settings into Page tab and remove Settings tab
All checks were successful
deploy / deploy (push) Successful in 3m37s

Custom page settings (title, slug, meta, published, navigation) now
appear as a collapsible section at the top of the Page tab. The
separate Settings tab has been fully removed.

- Add page_settings_section component to page_renderer.ex
- Remove dead :settings case from editor_panel_content
- Delete settings_editor.ex component entirely
- Remove SettingsEditor import from shop_components.ex
- Add .page-settings-* CSS styles
- Clean up old .settings-* CSS styles

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
jamey
2026-03-28 23:54:04 +00:00
parent 242fed0501
commit dd7146cb41
6 changed files with 267 additions and 439 deletions

View File

@@ -215,8 +215,8 @@ end
| 16 | Footer: read new fields | 15 | 30m | done |
| 17 | Move branding settings from Theme to Site | 4 | 1h | done |
| 18 | Theme tab: remove branding, polish remaining | 17 | 30m | done |
| 19 | Merge page settings into Page tab | — | 45m | planned |
| 20 | Remove Settings tab | 19 | 15m | planned |
| 19 | Merge page settings into Page tab | — | 45m | done |
| 20 | Remove Settings tab | 19 | 15m | done |
| 21 | Polish: responsive, empty states, validation | 1-20 | 1.5h | planned |
| 22 | Testing: all page types, edge cases | 21 | 30m | planned |
@@ -328,6 +328,25 @@ Moved branding settings from Theme tab to Site tab.
- Accent, hover, sale colours
- Customise accordion with typography, colours, layout, shape, products, product page groups
### Completed: Page Settings Migration (Tasks 19-20)
Merged custom page settings inline into Page tab and removed Settings tab.
**What changed:**
- Custom pages show a collapsible "Page settings" section at the top of the Page tab
- Contains: title, URL slug, meta description, published toggle, show in nav toggle, nav label, nav position
- System pages, product pages, and collection pages no longer show settings (editing done elsewhere)
- Settings tab button was already removed from UI; dead code removed from page_renderer.ex
- Deleted `settings_editor.ex` component entirely
**Files modified:**
- `lib/berrypod_web/page_renderer.ex` - Added `page_settings_section` component inline in `editor_sheet_content`
- `lib/berrypod_web/components/shop_components.ex` - Removed SettingsEditor import
- `assets/css/admin/components.css` - Added `.page-settings-*` styles, removed old `.settings-*` styles
**Files deleted:**
- `lib/berrypod_web/components/shop_components/settings_editor.ex`
## UI Wireframes
### Site tab layout