consolidate image serving and clean up pipeline

Move all image URL logic into ProductImage.url/2 and thumbnail_url/1,
remove dead on-demand generation code from Optimizer, strip controller
routes down to SVG recolor only, fix mockup startup check to verify all
variant formats, and isolate test image cache directory.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

lib/simpleshop_theme_web/components/shop_components/cart.ex

@@ -414,7 +414,7 @@ defmodule SimpleshopThemeWeb.ShopComponents.Cart do
   end
 
   defp cart_item_image(product) do
-    ProductImage.direct_url(Product.primary_image(product), 400)
+    ProductImage.url(Product.primary_image(product), 400)
   end
 
   # Shared delivery line used by both cart_drawer and order_summary.

lib/simpleshop_theme_web/components/shop_components/content.ex

@@ -1046,15 +1046,10 @@ defmodule SimpleshopThemeWeb.ShopComponents.Content do
     available = Optimizer.applicable_widths(assigns.source_width)
     default_width = Enum.max(available)
 
-    # Database images end with / (e.g., /images/{id}/variant/)
-    # Mockups use - separator (e.g., /mockups/product-1)
-    separator = if String.ends_with?(assigns.src, "/"), do: "", else: "-"
-
     assigns =
       assigns
       |> assign(:available_widths, available)
       |> assign(:default_width, default_width)
-      |> assign(:separator, separator)
 
     ~H"""
     <picture>
@@ -1069,7 +1064,7 @@ defmodule SimpleshopThemeWeb.ShopComponents.Content do
         sizes={@sizes}
       />
       <img
-        src={"#{@src}#{@separator}#{@default_width}.jpg"}
+        src={"#{@src}-#{@default_width}.jpg"}
         srcset={build_srcset(@src, @available_widths, "jpg")}
         sizes={@sizes}
         alt={@alt}
@@ -1163,12 +1158,8 @@ defmodule SimpleshopThemeWeb.ShopComponents.Content do
   end
 
   defp build_srcset(base, widths, format) do
-    # Database images end with / (e.g., /images/{id}/variant/)
-    # Mockups use - separator (e.g., /mockups/product-1)
-    separator = if String.ends_with?(base, "/"), do: "", else: "-"
-
     widths
     |> Enum.sort()
-    |> Enum.map_join(", ", &"#{base}#{separator}#{&1}.#{format} #{&1}w")
+    |> Enum.map_join(", ", &"#{base}-#{&1}.#{format} #{&1}w")
   end
 end

lib/simpleshop_theme_web/components/shop_components/layout.ex

@@ -382,7 +382,7 @@ defmodule SimpleshopThemeWeb.ShopComponents.Layout do
         |> Enum.with_index()
         |> Enum.map(fn {product, idx} ->
           image = Product.primary_image(product)
-          %{product: product, image_url: ProductImage.direct_url(image, 400), idx: idx}
+          %{product: product, image_url: ProductImage.url(image, 400), idx: idx}
         end)
       )
 
@@ -880,7 +880,7 @@ defmodule SimpleshopThemeWeb.ShopComponents.Layout do
     "/images/#{logo_image.id}/recolored/#{clean_color}"
   end
 
-  defp logo_url(logo_image, _), do: "/images/#{logo_image.id}"
+  defp logo_url(logo_image, _), do: "/image_cache/#{logo_image.id}.webp"
 
   # Logo content that links to home, except when already on home page.
   # This follows accessibility best practices - current page should not be a link.
@@ -970,7 +970,7 @@ defmodule SimpleshopThemeWeb.ShopComponents.Layout do
 
   defp header_background_style(settings, header_image) do
     "position: absolute; top: 0; left: 0; right: 0; bottom: 0; " <>
-      "background-image: url('/images/#{header_image.id}'); " <>
+      "background-image: url('/image_cache/#{header_image.id}.webp'); " <>
       "background-size: #{settings.header_zoom}%; " <>
       "background-position: #{settings.header_position_x}% #{settings.header_position_y}%; " <>
       "background-repeat: no-repeat; z-index: 0;"

lib/simpleshop_theme_web/components/shop_components/product.ex

@@ -213,7 +213,7 @@ defmodule SimpleshopThemeWeb.ShopComponents.Product do
           {nil, nil}
 
         Map.get(image, :image_id) ->
-          {"/images/#{image.image_id}/variant/", ProductImage.source_width(image)}
+          {"/image_cache/#{image.image_id}", ProductImage.source_width(image)}
 
         Map.get(image, :src) ->
           {Map.get(image, :src), ProductImage.source_width(image)}