migrate admin forms to inline feedback
All checks were successful
deploy / deploy (push) Successful in 1m26s
All checks were successful
deploy / deploy (push) Successful in 1m26s
Replace put_flash calls with inline feedback for form saves: - Email settings: "Now send a test email" after saving - Settings: from address and signing secret saves - Page editor: save button shows "Saved" checkmark Inline feedback appears next to save buttons and auto-clears after 3 seconds. Banners (put_flash) remain for page-level outcomes like deletions, state changes, and async operations. Task 3 of notification overhaul. Theme editor skipped as it auto-saves. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -97,7 +97,7 @@ defmodule BerrypodWeb.Admin.EmailSettingsTest do
|
||||
})
|
||||
|> render_submit()
|
||||
|
||||
assert html =~ "Settings saved"
|
||||
assert html =~ "Now send a test email"
|
||||
assert Settings.get_setting("email_adapter") == "brevo"
|
||||
end
|
||||
|
||||
|
||||
@@ -208,7 +208,7 @@ defmodule BerrypodWeb.Admin.PagesTest do
|
||||
|
||||
render_click(view, "save")
|
||||
|
||||
assert render(view) =~ "Page saved"
|
||||
assert has_element?(view, ".admin-inline-feedback-saved")
|
||||
|
||||
saved = Pages.get_page("home")
|
||||
assert length(saved.blocks) == 3
|
||||
|
||||
@@ -113,7 +113,7 @@ defmodule BerrypodWeb.Admin.SettingsTest do
|
||||
})
|
||||
|> render_submit()
|
||||
|
||||
assert html =~ "Webhook signing secret saved"
|
||||
assert has_element?(view, ".admin-inline-feedback-saved")
|
||||
assert html =~ "whsec_te•••456"
|
||||
end
|
||||
|
||||
@@ -261,7 +261,7 @@ defmodule BerrypodWeb.Admin.SettingsTest do
|
||||
|> form("form[phx-submit=\"save_from_address\"]", %{from_address: "shop@example.com"})
|
||||
|> render_submit()
|
||||
|
||||
assert html =~ "From address saved"
|
||||
assert has_element?(view, ".admin-inline-feedback-saved")
|
||||
assert Settings.get_setting("email_from_address") == "shop@example.com"
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user